convert fnv types into std #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fnvcrate hasn't seen some updates in some time. Thestdimplementation has improved greatly sincefnvwas introduced, making it on pair or even better thanfnv. Overall this removes a dependency and might bring some performance gain. I wasn't able to measure any sort of significant performance gain from this change. One of my applications went from a 246 microsecond cpu time down to 230 microseconds.There shouldn't be any breaking changes compared to what is released. I believe
descriptors_count()was the only public point where this was exposed and that change has not been released.