Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only the selected range of buffer and image views in synchronization #1880

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Apr 16, 2022

Changelog:

- **Breaking** `ImageViewCreateInfo` now has a single `subresource_range` field instead of separate fields for aspect, mip levels and array layers.
- **Breaking** The `aspects`, `mip_levels` and `array_layers` methods of `ImageViewAbstract` are removed, and replaced with a single `subresource_range` method.
- **Breaking** The `current_mip_levels_access` and `current_array_layers_access` methods of `ImageAccess` are removed.
- `BufferViewAbstract` now has a `range` method that returns the byte range of the underlying buffer that the view covers.

Command buffer synchronization now uses the specified ranges of buffer and image views instead of the whole buffer/image. I've also made it so that buffer and image ranges are passed correctly from a secondary command buffer to a primary one.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good!

@AustinJ235 AustinJ235 merged commit af930e5 into vulkano-rs:master Apr 24, 2022
AustinJ235 added a commit that referenced this pull request Apr 24, 2022
@Rua Rua deleted the buffer-image-view-sync branch May 31, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants