Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a number of items (mostly) related to documentation/commenting and marked "TODO" in the repository.
Specifically it:
ImageUseage
,transient_input_attachment()
, which creates anImageUseage
with the appropriate settings for that use. This is likely to be useful in other instances as well (see vulkano/src/image/usage.rs).shader!
macro to examples/src/bin/triangle-v1_3.rs and examples/src/bin/triangle.rs.ImageAttachment
(see vulkano/src/image/attachment.rs).All tests pass on my machine. This is my first ever pull request to a team project, so please forgive any errors I may have made. I am happy to make changes as needed to get this into shape for inclusion in the master branch.