Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better defaults for vulkano config #1942

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

hakolao
Copy link
Contributor

@hakolao hakolao commented Aug 3, 2022

With new vulkano (1.3), mac fails to unless khr_portability_enumeration is used.

thread 'main' panicked at 'Failed to create instance: IncompatibleDriver', vulkano-util/src/context.rs:132:14

I think the config defaults should cfg those for mac os by default. Of course, one can add them when using the VulkanoContext::new(), but I think these are better defaults. Also the default application_version is updated to V1_3.

@Rua Rua merged commit ac32c62 into vulkano-rs:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants