Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2007 fixes #2008

Merged
merged 1 commit into from
Oct 2, 2022
Merged

#2007 fixes #2008

merged 1 commit into from
Oct 2, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Sep 30, 2022

This fixes some issues that were left over after #2007:

  • The ensure_sendable test was failing.
  • The auto-generated code was triggering idiom warnings.
  • Idiom warnings weren't enabled on the other crates in Vulkano, I did that now and fixed any warnings.

@marc0246
Copy link
Contributor

Thanks 🙏

AustinJ235
AustinJ235 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@AustinJ235 AustinJ235 merged commit f78e06f into vulkano-rs:master Oct 2, 2022
@Rua Rua deleted the 2007-fixes branch October 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rua @marc0246 @AustinJ235