Fix physical device surface querying regression #2026 by removing surface caching #2027
Conversation
…d, fixing window resize bug
out of date. surface_capabilities, surface_formats, surface_present_modes and surface_support are no longer cached as it is proven that surface properties can change at runtime for a given surface/physical device.
|
Are you sure we need to ditch caching all-together? On my system, querying this info from the implementation is 800X slower. We could invalidate the caches where needed instead perhaps? |
|
problem is I can't see a way to do that... the surface and physical device handles stay the same, but drivers seem happy to change the data returned by VK_KHR_surface commands depending on when you do the query e.g. VkSurfaceCapabilitiesKHR.min/maxImageExtent due to the window being resized. you could assume that but basically |
|
I agree that caching the capabilities would be impractical, although possible. We would need to invalidate the cache on resize, which would pose no benefit as you likely only need that information when recreating the swapchain, so it would just overcomplicate things. About the other ones, I've looked through the specification repo but couldn't find anything specific about the lifetime of the info. |
|
After looking through the structs again, I really don't see any reason why surface_formats, surface_present_modes and surface_support would change during runtime. I'll add caching back for them, but keep surface_capabilities un-cached. |
|
Sounds good. |
…present_modes and surface_support, because unlike surface_capabilities, it is almost certain they won't change at runtime.
|
Thank you for catching this one! |
|
There's an error on MacOS, can you fix it? |
|
whoops missed that. pretty sure macos/ios will work now |
…moving surface caching (vulkano-rs#2027) * removed cache check for PhysicalDevice::surface_capabilities_unchecked, fixing window resize bug * Fixed bug where new caching functionality caused surface queries to be out of date. surface_capabilities, surface_formats, surface_present_modes and surface_support are no longer cached as it is proven that surface properties can change at runtime for a given surface/physical device. * Re-added caching for VK_KHR_surface structs surface_formats, surface_present_modes and surface_support, because unlike surface_capabilities, it is almost certain they won't change at runtime. * remove surface_capabilities cache from macos/ios to fix builds
Fixes #2026
Fixed regression bug where new caching functionality introduced in #2006 caused surface queries to be out of date.
surface_capabilities,surface_formats,surface_present_modesandsurface_supportare no longer cached as it is proven in #2026 that surface properties can change at runtime for a given surface/physical device.Also worth noting that requesting these structures doesn't happen too often so the performance impact will be minimal.