Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed queue family index count not being set in buffers and images #2034

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

daigennki
Copy link
Contributor

  1. Update documentation to reflect any user-facing changes - in this repository.

  2. Make sure that the changes are covered by unit-tests.

  3. Run cargo fmt on the changes.

  4. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  5. Describe in common words what is the purpose of this change, related
    Github Issues, and highlight important implementation aspects.

Changelog:

### Bugs fixed
- Queue family count isn't being set in either `ash::vk::BufferCreateInfo` or `ash::vk::ImageCreateInfo`

In either case of buffers or images, the bug occurred when using more than 1 queue family (not exclusive use). queue_family_index_count in the ash structs was not being explicitly set and was left as Default::default(), which is 0, making it in violation of the Vulkan spec (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkBufferCreateInfo-sharingMode-00914, https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkImageCreateInfo-sharingMode-00942) and potentially causing undefined behavior.

@Rua
Copy link
Contributor

Rua commented Oct 12, 2022

Thank you for the fix!

@Rua Rua merged commit 1bb2602 into vulkano-rs:master Oct 12, 2022
Rua added a commit that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants