Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safety checks to semaphores, add importing and exporting #2035

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Oct 12, 2022

Changelog:

### Additions
- Support for the `khr_external_semaphore_fd`, `khr_external_semaphore_win32` and `fuchsia_external_semaphore` extensions.
- `Semaphore::export_fd` is no longer unsafe.

This adds checks to make semaphores safe to use, but only in a very limited fashion for now. To keep the checks simple, there can't be more than one signal operation and one wait operation pending at any given time. This limitation will hopefully be lifted in the future.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AustinJ235 AustinJ235 merged commit 43223f5 into vulkano-rs:master Oct 13, 2022
AustinJ235 added a commit that referenced this pull request Oct 13, 2022
Rua added a commit that referenced this pull request Oct 13, 2022
@Rua Rua deleted the semaphore-checks branch December 6, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants