Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Near-full support for VK_KHR_synchronization2 #2043

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Oct 22, 2022

Changelog:

### Breaking changes
Changes to `PipelineStages`:
- The `transfer` flag has been renamed to `all_transfer`.

Changes to `SubpassDependency`, `MemoryBarrier`, `BufferMemoryBarrier`, `ImageMemoryBarrier`:
- Fields that start with `source_` have been renamed to `src_`.
- Fields that start with `destination_` have been renamed to `dst_`.

Changes to the `set_event` command:
- This command now takes a `DependencyInfo` instead of `PipelineStages`, to enable use of the `vkCmdSetEvent2` version.

### Additions
- Added support for all remaining `PipelineStages` and `AccessFlags`, including those from the `synchronization2` feature.
- Added support for `synchronization2` to the `set_event`, `reset_event` and `write_timestamp` commands, and to `SubpassDependency` when creating a render pass.
- Added the `wait_events` command to `SyncCommandBufferBuilder` and `UnsafeCommandBufferBuilder`.

Almost all of this extension is now implemented as far as possible. The only remaining parts are those that deal with device groups, which Vulkano doesn't have any support for yet anyway.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@AustinJ235 AustinJ235 merged commit 7e92f35 into vulkano-rs:master Oct 23, 2022
AustinJ235 added a commit that referenced this pull request Oct 23, 2022
Rua added a commit that referenced this pull request Oct 24, 2022
@Rua Rua deleted the synchronization2 branch December 6, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants