Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depth and stencil attachment check when building pipeline #2052

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

insertt
Copy link
Contributor

@insertt insertt commented Oct 28, 2022

Changelog:

### Bugs fixed
- Depth and stencil attachments are now properly checked when using dynamic rendering.
- Proper error (`NoStencilAttachment`) is now being returned if stencil attachment format is missing.

I've noticed these issues when tinkering with secondary buffers and dynamic rendering - there was no way to declare inheritance for depth attachments for secondary buffers, as it would result in pipeline validation error with or without it.

@Rua
Copy link
Contributor

Rua commented Oct 28, 2022

Oops! Thanks for finding and fixing those!

@Rua Rua merged commit 0b59b05 into vulkano-rs:master Oct 28, 2022
Rua added a commit that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants