Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, clippy warnings #2142

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Feb 15, 2023

Changelog:

### Public dependency updates
- [ash](https://crates.io/crates/ash) 0.37.2
- [bytemuck](https://crates.io/crates/bytemuck) 1.13
- [nalgebra](https://crates.io/crates/nalgebra) 0.32
- [winit](https://crates.io/crates/winit) 0.28

There seems to be something wrong with a dependency conflict in the gl-interop example. Maybe @fayalalebrun should have a look at that.

@fayalalebrun
Copy link
Contributor

The problem is that winit was updated to 0.28, but glium is still stuck on 0.27. Therefore the solution is to import winit 0.27 under a different alias and then change the code so that vulkano windows and glium windows are created using the correct winit version.

@Rua
Copy link
Contributor Author

Rua commented Feb 15, 2023

That doesn't seem possible, because the same event_loop variable is passed to both Glium and Vulkano-winit.

@fayalalebrun
Copy link
Contributor

I don't think it's necessary for both to have the same event loop. You'd probably need to run each event loop in its own thread however. It's also possible to run them in different processes, by sharing the FDs via a unix socket.

@Rua
Copy link
Contributor Author

Rua commented Feb 15, 2023

I will leave the errors as they are for this PR, and then you can solve it whatever way works best afterwards?

@fayalalebrun
Copy link
Contributor

I implemented what I mentioned: https://github.com/fayalalebrun/vulkano/tree/gl-interop-fix

It's compiling now, but it seems like the example is now segfaulting on my machine. Even previously working versions segfault, perhaps due to a GPU driver update. It would be good to know whether it works on your machine.

Also, we're no longer using this extension for compositing, as we've since moved to DMABuf via Wayland. I wonder if anybody uses this extension with Vulkano. If there no users perhaps it is not worth it to support it.

@AustinJ235 AustinJ235 merged commit 41ded32 into vulkano-rs:master Mar 6, 2023
AustinJ235 added a commit that referenced this pull request Mar 6, 2023
@Rua
Copy link
Contributor Author

Rua commented Mar 6, 2023

@fayalalebrun this is merged now. Can you make a followup PR?

@fayalalebrun
Copy link
Contributor

@Rua With that branch I linked? I'm not sure if it is correct, since it seems like even the older versions of the example which once worked no longer work on my system. I'm using RADV + RadeonSI, but sadly I have no easy access to a system with another driver to test.

@Rua
Copy link
Contributor Author

Rua commented Mar 6, 2023

You can do whatever you think is best to fix the errors that are currently happening, including removing the example.

@Rua Rua deleted the deps branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* Update dependencies, clippy warnings

* Remove allowed clippy lint that no longer triggers as of Rust 1.67.1
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants