-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateInfo for pipelines, require explicit pipeline layout creation #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0246
reviewed
Apr 22, 2023
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
…peline-create-info
marc0246
reviewed
Apr 22, 2023
Very nice, again one step closer to Vulkan with the pipeline create infos! |
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
…on (vulkano-rs#2186) * Add CreateInfo for pipelines, require explicit pipeline layout creation * Doc fixes * Add missing unsafe Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Add PipelineCreateFlags * Small fixes * -inline Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * -inline Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> --------- Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Remove:
Replace with:
This brings pipeline construction in line with other object types. Pipeline layout construction is no longer automatic in pipeline construction, but I made a new type to make it easier to auto-construct them separately.