Add safe Subbuffer::reinterpret[_ref] methods
#2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
* Correct naming mistake * Add `Subbuffer::reinterpret[_ref]` * Remove old conversion functions * Some fixes
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
Subbuffer::{try_cast, try_cast_slice, try_from_bytes}were modelled after bytemuck, but the issue is that since #2132 we have the ability to represent arbitrary unsized types in subbuffers, not just sized types and slices. So for instance there is currently no way to safely turn a subbuffer of bytes to a subbuffer of some custom DST. This PR addresses that by replacing those functions with just oneSubbuffer::reinterpret[_ref]that works for any combination of types.Changelog: