Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly aims to address the issue that errors are not formatted nicely when using
Result::unwrap
orResult::expect
.The formatting now looks like this, using a random validation error:
I mainly took inspiration from anyhow for the formatting.
Runtime errors look like this:
I also changed the existing
Display
implementation forRequiresOneOf
a little, to make it clearer that e.g. you need of of the features, not all of the features.It's important to note that old error types using
RequiresOneOf
are going to have a strange mix of the debug formattings until we replace them, so let's preferably do that soon. Not world-ending though.