Add support for inline uniform blocks #2225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Another nice-to-have feature, that was included in Vulkan 1.3. I also added backticks to all the code pieces in validation messages that were added in #2219, per Discord.
One important thing is still missing: the descriptor set allocator doesn't handle these descriptor types yet, it just asserts/panics. Descriptor pools have a new parameter,
max_inline_uniform_block_bindings
, but I don't know what the allocator should choose for that value. I can add it to this PR if there's an easy solution.