Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inline uniform blocks #2225

Merged
merged 6 commits into from
Jun 17, 2023
Merged

Add support for inline uniform blocks #2225

merged 6 commits into from
Jun 17, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 5, 2023

Changelog:

### Breaking changes
Changes to `DescriptorPool`:
- `DescriptorPool::new` now returns validation errors instead of panicking.
- `DescriptorPoolCreateInfo::can_free_descriptor_sets` has been replaced with a more generic `flags` field.

### Additions
- Added support for `InlineUniformBlock` descriptors.

Another nice-to-have feature, that was included in Vulkan 1.3. I also added backticks to all the code pieces in validation messages that were added in #2219, per Discord.

One important thing is still missing: the descriptor set allocator doesn't handle these descriptor types yet, it just asserts/panics. Descriptor pools have a new parameter, max_inline_uniform_block_bindings, but I don't know what the allocator should choose for that value. I can add it to this PR if there's an easy solution.

vulkano/src/descriptor_set/layout.rs Outdated Show resolved Hide resolved
vulkano/src/descriptor_set/layout.rs Outdated Show resolved Hide resolved
vulkano/src/descriptor_set/pool.rs Outdated Show resolved Hide resolved
@marc0246
Copy link
Contributor

Very nice, thanks! Don't worry about the descriptor set allocator for now, I'll fix it when I add StandardDescriptorSetAllocatorCreateInfo as planned (in a pretty obvious way). Note to self: add an example after that, as this is currently untested.

@marc0246 marc0246 merged commit f10c594 into vulkano-rs:master Jun 17, 2023
marc0246 added a commit that referenced this pull request Jun 17, 2023
@Rua Rua deleted the iub branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* Add support for inline uniform blocks

* Make this match exhaustive so it triggers if new descriptor types are added in future

* Return RuntimeError from pool allocation

* Doc improvement

* Doc fix

* Apply fixes
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants