Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could have lead to UB if the stars aligned just right. It only concerns reinterpretation of a lesser-aligned type to a custom DST that has a higher-aligned head plus a lesser-aligned tail:
The last line is UB because there could be another subbuffer or other allocation right after the given subbuffer, even though the
&mut Example
above has provenance over 3 bytes past the subbuffer, which could result in an aliasing mutable reference.At least
Subbuffer::reinterpret
hasn't been released yet. :)