Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidationError-ify GraphicsPipeline #2234

Merged
merged 7 commits into from
Jun 25, 2023
Merged

ValidationError-ify GraphicsPipeline #2234

merged 7 commits into from
Jun 25, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 23, 2023 •
edited
Loading

Changelog:

### Breaking changes
Changes to pipeline construction:
- `ViewportState` is now a standard struct with two fields, `viewports` and `scissors`.
- The `origin` and `dimensions` fields of `Viewport` and `Scissors` are renamed to `offset` and `extent` to match Vulkan.
- `Viewport::depth_range` is now an inclusive range.
- All fields of `AttachmentBlend` are renamed to match Vulkan.

Changes to pipeline caches:
- They are now constructed with the standard combination of a `new` constructor and a `PipelineCacheCreateInfo`.

Depends on #2233. This converts GraphicsPipeline and related types to use ValidationError.

@Rua Rua mentioned this pull request Jun 24, 2023
Merged
marc0246
marc0246 reviewed Jun 25, 2023
View reviewed changes
Copy link
Contributor

@marc0246 marc0246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge is incomplete, these should be gone now.

vulkano/src/lib.rs Outdated Show resolved Hide resolved
vulkano/src/lib.rs Outdated Show resolved Hide resolved
Rua and others added 2 commits June 25, 2023 17:47
@Rua @marc0246
Update vulkano/src/lib.rs
5619a70 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@Rua @marc0246
Update vulkano/src/lib.rs
44eab25 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@marc0246
Copy link
Contributor

LGTM!

We'll have to ignore the build failure, I tested it on Windows and there's no problems.

@marc0246 marc0246 merged commit 6967734 into vulkano-rs:master Jun 25, 2023
marc0246 added a commit that referenced this pull request Jun 25, 2023
@marc0246
#2234 changelog
2d6ff10
@Rua Rua mentioned this pull request Jun 27, 2023
Merged
@Rua Rua deleted the pipeline-validation branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @marc0246 @hakolao
ValidationError-ify GraphicsPipeline (vulkano-rs#2234)
bedf4c4 
* Add `RequiresAllOf`, automatically enable required extensions and features

* Add more missing backticks and backslashes to error messages

* Use updated VUIDs that require `acceleration_structure`

* ValidationError-ify `GraphicsPipeline`

* Update vulkano/src/lib.rs

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

* Update vulkano/src/lib.rs

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

---------

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2234 changelog
ec1a109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc0246 marc0246 marc0246 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @marc0246