Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationError-ify memory and memory allocators #2237

Merged
merged 8 commits into from
Jun 27, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 25, 2023

Changelog:

### Breaking changes
Changes to errors:
- `AllocationCreationError` is renamed to `MemoryAllocatorError`.
- `SuballocationCreationError` is renamed to `SuballocatorError`.

Depends on #2233. More conversions, no further changes.

Copy link
Contributor

@marc0246 marc0246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snuck in again >_<

vulkano/src/lib.rs Outdated Show resolved Hide resolved
vulkano/src/lib.rs Outdated Show resolved Hide resolved
Rua and others added 2 commits June 26, 2023 11:40

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@marc0246 marc0246 merged commit b4f4090 into vulkano-rs:master Jun 27, 2023
marc0246 added a commit that referenced this pull request Jun 27, 2023

Verified

This commit was signed with the committer’s verified signature.
@Rua Rua deleted the memory-validation branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* Add `RequiresAllOf`, automatically enable required extensions and features

* Add more missing backticks and backslashes to error messages

* Use updated VUIDs that require `acceleration_structure`

* Fix `check_requirements`

* ValidationError-ify memory and memory allocators

* Update vulkano/src/lib.rs

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

* Update vulkano/src/lib.rs

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>

---------

Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants