Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free in debug utils names setup #2243

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix use-after-free in debug utils names setup #2243

merged 1 commit into from
Jun 29, 2023

Conversation

HadrienG2
Copy link
Contributor

This fixes the use-after-free but that I discovered while playing around with debug utils names (first reported in #2242).

  1. Update documentation to reflect any user-facing changes - in this repository. => No docs change

  2. Make sure that the changes are covered by unit-tests. => UB cannot be covered by unit tests I think?

  3. Run cargo fmt on the changes.

  4. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  5. Describe in common words what is the purpose of this change, related
    Github Issues, and highlight important implementation aspects. => See above.

Changelog:

### Bugs fixed
- `Device::set_debug_utils_object_name` no longer exhibits use-after-free UB.

@Rua Rua merged commit 65faf9b into vulkano-rs:master Jun 29, 2023
@Rua
Copy link
Contributor

Rua commented Jun 29, 2023

Thanks for spotting and fixing it!

Rua added a commit that referenced this pull request Jun 29, 2023
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants