Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidationError-ify samplers #2245

Merged
merged 2 commits into from
Jun 30, 2023
Merged

ValidationError-ify samplers #2245

merged 2 commits into from
Jun 30, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 29, 2023

Changelog:

### Breaking changes
Changes to samplers:
- The `sampler` module is now a submodule of `image`.

Since samplers are only ever used with images, it made sense to me for them to be placed there.

@marc0246 marc0246 merged commit 204811d into vulkano-rs:master Jun 30, 2023
marc0246 added a commit that referenced this pull request Jun 30, 2023
@marc0246
#2245 changelog
6a3fbf5
@Rua Rua deleted the sampler-validation branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
ValidationError-ify samplers (vulkano-rs#2245)
cebcc62 
* ValidationError-ify samplers

* Fix doctests
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2245 changelog
6dc9e97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @marc0246