Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Following KhronosGroup/Vulkan-Docs#2165, it seems that the Vulkan definition of a "valid VkFormat value" includes
UNDEFINED
. So this makes that a valid enum value for Vulkano as well, and removesOption
APIs where appropriate.I haven't done it for attachment formats for dynamic rendering. In this case,
None
doesn't just mean "undefined format", but "no attachment". It matches with the fields ofRenderingInfo
where the attachments that are absent are also represented asNone
.