Improved display of some error and remove unimplemented! for UnexpectedImageLayout display
#2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectedImageLayout` display It appeared to me quite often that I've it some error and the message was lost on display because some `Display` implementation don't record the cause. Improved some of those that I've spotted while debugging some bad code I had. Also removed the `unimplemented` for `AccessError::UnexpectedImageLayout` and now giving a more descriptive message.
|
Looks good, thank you for the improvements! |
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
…ectedImageLayout` display (vulkano-rs#2305) It appeared to me quite often that I've it some error and the message was lost on display because some `Display` implementation don't record the cause. Improved some of those that I've spotted while debugging some bad code I had. Also removed the `unimplemented` for `AccessError::UnexpectedImageLayout` and now giving a more descriptive message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to reflect any user-facing changes - in this repository.
Make sure that the changes are covered by unit-tests. (N/A)
Run
cargo fmton the changes.Please put changelog entries in the description of this Pull Request
Changelog:
It happened to me quite often that I've it some error and the message was lost on display because some
Displayimplementation don't record the cause. Improved some of those that I've spotted while debugging some bad code I had.Also removed the
unimplementedforAccessError::UnexpectedImageLayoutand now giving a more descriptive message.