Fix validation and errors in MemoryAllocator
#2306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some extremely strange validation left over from #1997, and some other panics.
Seeing as allocation of
DeviceMemory
is not on the hot path whatsoever, I don't understand why the allocator didn't just call the validated allocation function before, but rather panicking. This also made it harder to implement a custom memory allocator as there were both checked and unchecked versions of the methods for no reason. I also removed some nonsensical validation that didn't do anything to begin with, and the panic when picking a memory type fails was replaced by an error variant.Changelog: