Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2316, the suballocators no longer need to be
Sync
like they used to becauseMemoryAlloc
would hold a reference to them. Instead, this gives the user more freedom in how they synchronize the suballocator(s), if at all. In particular in the use case where one has thread-local suballocators there is no reason for this internal sync, but also it can lead to multiple layers of sync.GenericMemoryAllocator
would use anRwLock
to lock the pool, and then each block would use anotherMutex
internally for no reason in particular. (An argument for fine-grained locking can be made, however that isn't an argument for internal locking). The original intent when working on #1997 was to support both locking and lock-free suballocators, which sounded good in my head at the time but isn't practical at all when you think about it. I invite you to read the comments regarding this that are now gone (because the whole algorithm was simplified a bunch thanks to this) and facepalm in unison with me.Changelog: