Fix suballocator cleanup #2323
Merged
Fix suballocator cleanup #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
* Fix suballocator cleanup * impl `Debug` for `dyn Suballocator`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #2316 where
GenericMemoryAllocator<BumpAllocator>would create aliasing allocations. Also fixes the last part of the strange API decisions from #1997, removingSuballocator::NEEDS_CLEANUP(this is already documented in the changelog under the umbrella that the whole API was reworked). Thanks to this,Suballocatoris now object-safe, so I've implementedDebugfordyn Suballocatoras well.