Refactor some descriptor set/allocation things #2357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
What started off as a simple doc fix got a bit bigger...
This PR makes descriptor set allocation behave a little more like command buffer allocation:
UnsafeDescriptorSet
now holds onto the allocation, just likeUnsafeCommandBuffer
.DescriptorPoolAlloc
objects, in the same way that command pools allocateCommandPoolAlloc
objects. Both of these types hold information that was passed to theallocate_*
function (for descriptor sets, that means the layout and variable count).UnsafeDescriptorSet
now validates what it can, but without tracking any state or holding onto any resources, just likeUnsafeCommandBufferBuilder
.The
DescriptorSetInner
type ended up superfluous and was removed altogether.