Fix unnecessarily strict validation for DRM format modifiers #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinJ235
pushed a commit
that referenced
this pull request
Mar 3, 2024
* Add runtime SPIR-V validation * Remove copyright message * fmt * Up vk version in shader compilation (#2467) * Up vk version in shader compilation * Update test in codegen.rs * cargo +nightly fmt * Update lib.rs * clippy + fmt fixes * simplify changes * post merge * #2467 changelog * Remove windows specific dnd disable (#2474) * Fix unnecessarily strict validation for DRM format modifiers (#2469) * #2469 changelog * Add support for querying memory requirements directly from the device (#2470) * #2470 changelog * Make image_index and final_views accessible, and add new example. (#2473) * Make image_index and final_views accessible, and new example. The first 2 changes should make creating frame buffers easier. The new example should make it easier to learn vulkano-util. * Remove unnecessary imports, and run clippy. * Run fmt. * .acquire() no longer returns image_index * rename final_views() to swapchain_image_views() The name change makes it more consistent with swapchain_image_view(). Personally I don't understand why the field name is final_views, yet we externally in function names refer to it as swapchain image views and such like. * Fractal example no longer creates framebuffer every frame. * Game of life example no longer creates framebuffer every frame. (Also removed a piece of code I had commented out, but had forgotten to remove from the fractal example.) * Rename if_recreate_swapchain to on_recreate_swapchain and update acquire() documentation. to on_recreate_swapchain * on_recreate_swapchain is now impl FnOnce instead of generics based FnMut Thanks marc0246! Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Replace empty comment with an actual comment. --------- Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Fix `VulkanoWindowRenderer::swapchain_image_views` return type I have only noticed this as I was writing the changelog. @coolcatcoder for future reference, `&Vec<T>` is an anti-pattern. There's nothing more you can do with it than with `&[T]` (because the reference is immutable) and it means that we can't use a different underlying buffer without a breaking change. * #2473 changelog * Fix `VulkanoWindowRenderer::acquire` taking `&Vec<T>` as well * Replace cgmath with glam in the examples (#2475) * Replace cgmath with glam in the examples * Implement type_for_format! for glam * Remove comment where I'm freaking out because of OpenGL flashbacks * Update Cargo.toml Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Update vulkano/autogen/formats.rs Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Fix glam type_for_format * Format the code --------- Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * #2475 changelog * Fix alignment checks when allocating buffers (#2476) * #2476 changelog * Add `DepthState::reverse` helper method (#2483) * #2483 changelog * Add runtime SPIR-V validation * Remove copyright message * fmt --------- Co-authored-by: maratik123 <marat.buharov@gmail.com> Co-authored-by: Okko Hakola <okkohakola@gmail.com> Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> Co-authored-by: Katt <51190960+coolcatcoder@users.noreply.github.com> Co-authored-by: stefnotch <stefnotch@users.noreply.github.com> Co-authored-by: José Miguel Sánchez García <soy.jmi2k@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
The previous code rejected leaving
drm_format_modifier_plane_layoutsempty ifdrm_format_modifierscontained exactly one element. However, this should be allowed; fillingdrm_format_modifier_plane_layoutsis always optional.