Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #2497

Merged
merged 16 commits into from
Mar 13, 2024
Merged

Code cleanup #2497

merged 16 commits into from
Mar 13, 2024

Conversation

maratik123
Copy link
Contributor

@maratik123 maratik123 commented Mar 13, 2024 •
edited
Loading

  1. Update documentation to reflect any user-facing changes - in this repository.

  2. Make sure that the changes are covered by unit-tests.

  3. Run cargo clippy on the changes.

  4. Run cargo +nightly fmt on the changes.

  5. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  6. Describe in common words what is the purpose of this change, related
    Github Issues, and highlight important implementation aspects.

marc0246
marc0246 reviewed Mar 13, 2024
View reviewed changes
vulkano/src/buffer/mod.rs Outdated Show resolved Hide resolved
vulkano/src/buffer/subbuffer.rs Outdated Show resolved Hide resolved
vulkano/src/command_buffer/commands/acceleration_structure.rs Outdated Show resolved Hide resolved
vulkano/src/buffer/mod.rs Outdated Show resolved Hide resolved
vulkano/src/command_buffer/commands/query.rs Outdated Show resolved Hide resolved
vulkano/src/swapchain/mod.rs Outdated Show resolved Hide resolved
vulkano/src/swapchain/surface.rs Outdated Show resolved Hide resolved
vulkano/src/sync/fence.rs Outdated Show resolved Hide resolved
vulkano/src/sync/pipeline.rs Outdated Show resolved Hide resolved
vulkano/src/sync/semaphore.rs Outdated Show resolved Hide resolved
@marc0246
Copy link
Contributor

marc0246 commented Mar 13, 2024 •
edited
Loading

Btw, markdown checkboxes work like this:

  • Unchecked checkboxes are [ ] with a space in the middle.
  • Checked checkboxes are [x] with a letter X in the middle.

maratik123 and others added 10 commits March 13, 2024 12:39
@maratik123 @marc0246
Update vulkano/src/command_buffer/commands/query.rs
f1e3aee 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/buffer/subbuffer.rs
d7d7d54 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/buffer/mod.rs
459b790 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/swapchain/mod.rs
955ae89 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/sync/fence.rs
fdbcbbc 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/sync/semaphore.rs
de907f7 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/sync/pipeline.rs
939c256 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/descriptor_set/mod.rs
0e887d4 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Update vulkano/src/image/mod.rs
761f3ae 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 @marc0246
Apply suggestions from code review
d76f87f 
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
@maratik123 maratik123 changed the title Code cleanup [WIP] Code cleanup Mar 13, 2024
@maratik123 maratik123 marked this pull request as draft March 13, 2024 09:49
@maratik123 maratik123 changed the title [WIP] Code cleanup Code cleanup Mar 13, 2024
@maratik123 maratik123 marked this pull request as ready for review March 13, 2024 16:14
@marc0246
Copy link
Contributor

Thanks!

@marc0246 marc0246 merged commit f911996 into vulkano-rs:master Mar 13, 2024
5 checks passed
@maratik123 maratik123 deleted the fix-warns branch March 13, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc0246 marc0246 marc0246 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maratik123 @marc0246