Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass timeout to acquire #2503

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Conversation

hakolao
Copy link
Contributor

@hakolao hakolao commented Mar 23, 2024

It seems that (at least on windows), the timeout param is required. Min 2 Swapchain images is also.

hakolao/egui_winit_vulkano#61

VUID-vkAcquireNextImageKHR-surface-07783(ERROR / SPEC): msgNum: -1391585802 - Validation Error: [ VUID-vkAcquireNextImageKHR-surface-07783 ] Object 0: handle = 0xcb1c7c000000001b, type = VK_OBJECT_TYPE_SWAPCHAIN_KHR; | 
MessageID = 0xad0e15f6 | vkAcquireNextImageKHR: Application has already previously acquired 1 image from swapchain. Only 1 is available to be acquired using a timeout of UINT64_MAX (given the swapchain has 2, and VkSurfaceCapabilitiesKHR::minImageCount is 2). The Vulkan spec states: If forward progress cannot be guaranteed for the surface used to create the swapchain member of pAcquireInfo, the timeout member of pAcquireInfo must not 
be UINT64_MAX (https://vulkan.lunarg.com/doc/view/1.3.243.0/windows/1.3-extensions/vkspec.html#VUID-vkAcquireNextImageKHR-surface-07783)
    Objects: 1
        [0] 0xcb1c7c000000001b, type: 1000001000, name: NULL

So thus changing the acquire api to let user to pass the timeout param.

@Rua Rua merged commit 15f60f0 into vulkano-rs:master Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants