Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for ext_conservative_rasterization #2508

Merged
merged 27 commits into from
Mar 29, 2024
Merged

support for ext_conservative_rasterization #2508

merged 27 commits into from
Mar 29, 2024

Conversation

LukeP0WERS
Copy link
Contributor

added a conservative rasterization state to the graphics pipeline and the dynamic states for it. i have tested it with my own project and everything seems to be working.

Changelog:

### Additions
- Support for the `ext_conservative_rasterization` extension.
- Support for the `extended_dynamic_state3_conservative_rasterization_mode` device feature.
- Support for the `extended_dynamic_state3_extra_primitive_overestimation_size` device feature.

@Rua
Copy link
Contributor

Rua commented Mar 29, 2024 •
edited
Loading

A few VUIDs are not validated yet:

  • VUID-VkGraphicsPipelineCreateInfo-conservativePointAndLineRasterization-08892
  • VUID-vkCmdDraw*-conservativePointAndLineRasterization-07499 (for every draw command, using the vuids! macro again)

LukeP0WERS and others added 3 commits March 29, 2024 12:19
@LukeP0WERS @Rua
add vuid
5c98f41 
Co-authored-by: Rua <ruawhitepaw@gmail.com>
@LukeP0WERS @Rua
add vuid
5ef2c8b 
Co-authored-by: Rua <ruawhitepaw@gmail.com>
@LukeP0WERS
more validation
66f6af8
@LukeP0WERS
Copy link
Contributor Author

not sure how to do VUID-vkCmdDraw*-conservativePointAndLineRasterization-07499

LukeP0WERS and others added 3 commits March 29, 2024 14:19
@LukeP0WERS @Rua
Update vulkano/src/pipeline/graphics/mod.rs
14017c8 
Co-authored-by: Rua <ruawhitepaw@gmail.com>
@LukeP0WERS @Rua
Update vulkano/src/pipeline/graphics/mod.rs
5be5599 
Co-authored-by: Rua <ruawhitepaw@gmail.com>
@LukeP0WERS @Rua
Update vulkano/src/pipeline/graphics/mod.rs
845ca4c 
Co-authored-by: Rua <ruawhitepaw@gmail.com>
@Rua Rua merged commit 5dab2df into vulkano-rs:master Mar 29, 2024
5 checks passed
Rua added a commit that referenced this pull request Mar 29, 2024
@Rua
#2508 changelog
55556bb
@LukeP0WERS LukeP0WERS deleted the conservative_rasterization branch March 29, 2024 19:36
Rua added a commit to Rua/vulkano that referenced this pull request Mar 30, 2024
@Rua
Fix for vulkano-rs#2508
17dfc5d
@marc0246
Copy link
Contributor

marc0246 commented Apr 7, 2024

Note that ConservativeRasterizationState is an extension to RasterizationState, not to GraphicsPipelineCreateInfo. We should fix this before releasing.

marc0246 pushed a commit that referenced this pull request Apr 8, 2024
@Rua
Enable and fix pointer cast lints (#2507)
fe74e0a 
* Enable and fix pointer cast lints

* Fix for #2508

* Use coercion instead of `ptr::from_ref`

* Search-and-replace fail

* Replace `addr_of!` + `cast`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rua Rua Rua left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeP0WERS @Rua @marc0246