Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details for error messages in validate_pipeline_descriptor_sets #2509

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

ComfyFluffy
Copy link
Contributor

@ComfyFluffy ComfyFluffy commented Mar 29, 2024

Add details for format and image_view_type checks in RecordingCommandBuffer::validate_pipeline_descriptor_sets to make debugging easier.

@Rua
Copy link
Contributor

Rua commented Mar 29, 2024

Thanks, I agree that this helps. Maybe the messages would be clearer still if the message said "pipeline requires X, but image view type is Y", instead of "expected" and "found"? Then there's no doubt on what pieces are referred to.

@Rua Rua merged commit 78f3f9f into vulkano-rs:master Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants