Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MSRV to 1.72.0 #2516

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Set MSRV to 1.72.0 #2516

merged 4 commits into from
Apr 19, 2024

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Apr 9, 2024

Changelog:

### Public dependency updates
- Rust version: 1.72.0

Rather than speculating about the MSRV forever, I figured it would be best to just set it. I've reverted the ptr::from_ref additions, since those bump it to 1.76.0, which is a bit too new to require IMO. Rust 1.78 is expected to come with a Clippy lint that checks the code against the MSRV, so that should help us realise when we're breaking it. Note that unknown Clippy lints only generate warnings, so we can include them even if they are not supported by the MSRV (as long as CI is using the newest version).

@marc0246
Copy link
Contributor

I like the workspace inheritance. That was long overdue 👍 The readme field can be a inherited as well if you like (it would have to be set to README.md in the root manifest). But it's weird that there's both field.workspace = true and field = { workspace = true }. I would prefer it if you picked one style, doesn't matter which.

@marc0246 marc0246 merged commit 87993aa into vulkano-rs:master Apr 19, 2024
5 checks passed
marc0246 added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants