Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Rather than speculating about the MSRV forever, I figured it would be best to just set it. I've reverted the
ptr::from_ref
additions, since those bump it to 1.76.0, which is a bit too new to require IMO. Rust 1.78 is expected to come with a Clippy lint that checks the code against the MSRV, so that should help us realise when we're breaking it. Note that unknown Clippy lints only generate warnings, so we can include them even if they are not supported by the MSRV (as long as CI is using the newest version).