Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one error in SubpassDescription::validate #2556

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fix off-by-one error in SubpassDescription::validate #2556

merged 2 commits into from
Aug 14, 2024

Conversation

interacsion
Copy link
Contributor

Changelog:

### Bugs fixed
- off-by-one error in `SubpassDescription::validate`

@interacsion interacsion force-pushed the fix-viewmask-validation branch from 894325c to 3580a0c Compare August 13, 2024 15:02
@marc0246
Copy link
Contributor

Much appreciated. However, I would have preferred to switch the >= comparison to > instead, as it avoids the pesky as casts. Ideally the variable would be renamed to reflect the fact that it's not an index (hard).

@marc0246 marc0246 merged commit 817b52c into vulkano-rs:master Aug 14, 2024
6 checks passed
@interacsion interacsion deleted the fix-viewmask-validation branch August 14, 2024 05:17
marc0246 added a commit that referenced this pull request Aug 15, 2024
@marc0246
#2556 changelog
b2a93d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@interacsion @marc0246