Add PhysicalDevice::presentation_support
#2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0246
force-pushed
the
presentation-support
branch
3 times, most recently
from
2d8e44b
to
be5fa57
Compare
Rua
reviewed
Sep 11, 2024
| @@ -34,6 +34,10 @@ vulkano-macros = { workspace = true, optional = true } | |||
| objc = { workspace = true } | |||
| core-graphics-types = { workspace = true } | |||
|
|
|||
| [target.'cfg(any(target_os = "dragonfly", target_os = "freebsd", target_os = "hurd", target_os = "illumos", target_os = "linux", target_os = "netbsd", target_os = "openbsd", target_os = "solaris"))'.dependencies] | |||
There was a problem hiding this comment.
Wouldn't it be easier to write something like:
cfg(all(unix, not(target_os = "foo"), not(target_os = "bar")))
There was a problem hiding this comment.
Easier in what way? The list would be longer. But that's besides the point. I explicitly did not want to do that because I really don't like the idea of opt-out conditional compilation, as new targets can always be added.
marc0246
force-pushed
the
presentation-support
branch
from
be5fa57
to
f488c3a
Compare
|
Looks good! Can you fix the conflict, then I'll merge. |
marc0246
force-pushed
the
presentation-support
branch
from
f488c3a
to
74f890e
Compare
|
Rebased. |
|
I should have merged... that compare is useless to see what changed. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function that abstracts away the platform-specific presentation support calls akin to
Surface::from_window, allowing you to determine presentation support to the surface of any window of a given event loop. This addresses two issues:Resumedcallback, which makes people think that you have to create the whole device in that callback, when that's not the case. This addition is going to make updating to winit 0.30 easier.PhysicalDevice::surface_support. This also fixes the issues that the multi-window example was having.PhysicalDevice::surface_supportis essentially only usable if you have a window since right after the creation of the event loop and when the window exists for the app's lifetime. Therefore, I replaced allPhysicalDevice::surface_supportcalls in the examples withPhysicalDevice::presentation_supportto promote the better alternative (and for the future when we update to winit 0.30).Unfortunately, this function was not implementable without adding dependencies for X11 libraries on X11 platforms. I added a default feature same as winit does, so the user can disable the dependencies if they e.g. only support Wayland.
Changelog: