Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task graph [5/10]: the new command buffer #2567

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

marc0246
Copy link
Contributor

@marc0246 marc0246 commented Sep 12, 2024

Follow up to #2560, implementing the new command buffer.

This is a copy of the old command buffer, the only difference is that this command buffer accepts Id<Resource>s rather than Arc<Resource>s and takes everything in by reference. I converted the rest of vulkano-taskgraph to take borrowed values as well. This is a first step towards eradicating owned collections in vulkano's public API.

I added a bloom example because it's a very good demonstration of the task graph:

  • It uses a task graph with multiple tasks, some doing graphics and some doing compute.
  • It does subresource accesses.
  • The bloom task does manual pipeline barriers.

@marc0246 marc0246 force-pushed the taskgraph-5 branch 4 times, most recently from ae270da to f685322 Compare September 13, 2024 01:33
@marc0246 marc0246 marked this pull request as draft September 13, 2024 09:42
@marc0246 marc0246 force-pushed the taskgraph-5 branch 13 times, most recently from af3c1be to 795741d Compare September 17, 2024 03:50
@marc0246 marc0246 marked this pull request as ready for review September 17, 2024 04:28
@Rua Rua merged commit bad11ee into vulkano-rs:master Sep 20, 2024
6 checks passed
@marc0246 marc0246 deleted the taskgraph-5 branch September 20, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants