-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial support for khr_fragment_shading_rate
#2574
Conversation
I think it looks wonderful! |
We should definitely add this to the task graph's command buffer (doesn't have to be in this PR), as any contribution to the old command buffer is instant legacy code. The old command buffer will be deprecated in the release after the next and eventually removed entirely together with |
This supports all but per-region fragment shading rate, which is a bit more involved. Perhaps a future PR? |
khr_fragment_shading_rate
khr_fragment_shading_rate
Looks good! Could you add a short documentation to the top of the |
3d1a11f
to
6dd8caa
Compare
In writing the docs, I realised I don't validate that |
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
Could you please format the validation messages like they are elsewhere? That is, use backticks around arguments/code and use line continuation to ensure they don't end up longer than 100 columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It LGTM; I just have some nits remaining.
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
Unfortunately, I don't have an answer for your earlier question. It looks as though there is no VUID specifically for |
This adds partial support for
khr_fragment_shading_rate
.FragmentShadingRateState
forGraphicsPipeline
DynamicState::FragmentShadingRate
andset_fragment_shading_rate
Per-region supportVkFragmentShadingRateAttachmentInfoKHR
Changelog: