Payment support for confidential addresses #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altafan
requested changes
Jun 8, 2020
altafan
requested changes
Jun 9, 2020
altafan
changed the title
tiero
requested changes
Jun 9, 2020
There was a problem hiding this comment.
Could you add confidential examples as documentation in examples_test.go? So we can have it here https://pkg.go.dev/github.com/vulpemventures/go-elements@v0.0.1/payment?tab=doc
altafan
requested changes
Jun 9, 2020
altafan
approved these changes
Jun 9, 2020
tiero
requested changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before there was no option to create p2pkh and p2sh confidential addresses using payment package.
After the methods ConfidentialPubKeyHash/ConfidentialScriptHash are added, it is possible to convert create confidential p2pkh and p2sh addresses.
It closes #83 .
It closes #85.
Please @altafan can you review this?