Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure OP_CHECKLOCKTIMEVERIFY & OP_CHECKSEQUENCEVERIFY are converted correctly #116

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Ensure OP_CHECKLOCKTIMEVERIFY & OP_CHECKSEQUENCEVERIFY are converted correctly #116

merged 1 commit into from
Feb 1, 2024

Conversation

Czino
Copy link

@Czino Czino commented Jan 31, 2024

I found that OP_CHECKLOCKTIMEVERIFY & OP_CHECKSEQUENCEVERIFY are returned as OP_NOP2 and OP_NOP3 when calling script.toASM().

That's because the order is important.

@tiero tiero requested a review from altafan January 31, 2024 18:23
@altafan
Copy link
Collaborator

altafan commented Feb 1, 2024

@Czino thanks for the contribution, nice catch! 👀

@altafan altafan removed the request for review from louisinger February 1, 2024 12:52
@altafan altafan merged commit 068adfe into vulpemventures:master Feb 1, 2024
4 checks passed
@Czino Czino deleted the bugfix/op-code-order branch February 1, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altafan altafan altafan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Czino @altafan