Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): change fetchmeta insert order #223

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

If an error occurs during the first fetch, it is required to clean the DB during the second Insert.
The old data can be deleted when updating between the same schema versions.
To avoid this problem, insert FetchMeta first.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Sep 22, 2021
@kotakanbe kotakanbe merged commit d45a5f7 into master Sep 22, 2021
@MaineK00n MaineK00n deleted the MaineK00n/change-fetchmeta-insert-order branch September 22, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants