Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking-change(redis): deprecated expire option #225

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

Expire was introduced to ensure safe operation in Redis, but since expire can only be set per key, it is not very useful for Sets and Hash.
Therefore, if there is any old content in each fetch, it will be deleted.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO

Reference

@MaineK00n MaineK00n self-assigned this Oct 3, 2021
@kotakanbe kotakanbe self-requested a review October 3, 2021 22:13
@kotakanbe kotakanbe merged commit 4d1f7ac into master Oct 3, 2021
@kotakanbe
Copy link
Collaborator

 ubuntu@dev  ~│g│s│g│v│go-cve-dictionary  ⎇ MaineK00n/deprecated-expire~  make diff-server-redis
integration/go-cve.old server --dbtype redis --dbpath "redis://127.0.0.1:6379/0" --port 1325 > /dev/null 2>&1 &
integration/go-cve.new server --dbtype redis --dbpath "redis://127.0.0.1:6380/0" --port 1326 > /dev/null 2>&1 &
make diff-cveid
make[1]: Entering directory '/home/ubuntu/go/src/github.com/vulsio/go-cve-dictionary'
INFO[10-04|07:51:39] start server mode test(mode: cves)
INFO[10-04|07:51:39] check the communication with the server
INFO[10-04|07:51:39] communication with the server has been confirmed
make[1]: Leaving directory '/home/ubuntu/go/src/github.com/vulsio/go-cve-dictionary'
make diff-cpes
make[1]: Entering directory '/home/ubuntu/go/src/github.com/vulsio/go-cve-dictionary'
INFO[10-04|07:51:47] start server mode test(mode: cpes)
INFO[10-04|07:51:47] check the communication with the server
INFO[10-04|07:51:47] communication with the server has been confirmed
INFO[10-04|08:16:34] start server mode test(mode: cpe_ids)
INFO[10-04|08:16:34] check the communication with the server
INFO[10-04|08:16:34] communication with the server has been confirmed
make[1]: Leaving directory '/home/ubuntu/go/src/github.com/vulsio/go-cve-dictionary'
pkill go-cve.old
pkill go-cve.new
 ✗  ubuntu@dev  ~│g│s│g│v│go-cve-dictionary  ⎇ MaineK00n/deprecated-expire~  integration/go-cve.new version
go-cve-dictionary v0.8.1 1dfddda
 ubuntu@dev  ~│g│s│g│v│go-cve-dictionary  ⎇ MaineK00n/deprecated-expire~  integration/go-cve.old version
go-cve-dictionary v0.8.1 cf3186e

@kotakanbe kotakanbe deleted the MaineK00n/deprecated-expire branch October 12, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants