Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use pure go sqlite driver #321

Merged
merged 1 commit into from
May 10, 2023
Merged

refactor: use pure go sqlite driver #321

merged 1 commit into from
May 10, 2023

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Apr 27, 2023

What did you implement:

use pure go sqlite driver

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

before

$ CGO_ENABLED=0 go build -ldflags "-X 'github.com/vulsio/go-cve-dictionary/config.Version=v0.8.3' -X 'github.com/vulsio/go-cve-dictionary/config.Revision=30c20b8'" -o go-cve-dictionary main.go
# gorm.io/driver/sqlite
../../../../go/pkg/mod/gorm.io/driver/sqlite@v1.5.0/error_translator.go:9:35: undefined: sqlite3.ErrNoExtended
../../../../go/pkg/mod/gorm.io/driver/sqlite@v1.5.0/error_translator.go:14:36: undefined: sqlite3.Error

after

$ CGO_ENABLED=0 go build -ldflags "-X 'github.com/vulsio/go-cve-dictionary/config.Version=v0.8.3' -X 'github.com/vulsio/go-cve-dictionary/config.Revision=b37c4ea'" -o go-cve-dictionary main.go

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Apr 27, 2023
@MaineK00n MaineK00n force-pushed the MaineK00n/purego branch 4 times, most recently from 00b6b40 to 67ea039 Compare April 27, 2023 04:12
@MaineK00n MaineK00n marked this pull request as draft April 27, 2023 04:25
@MaineK00n MaineK00n marked this pull request as ready for review April 27, 2023 05:18
@MaineK00n MaineK00n merged commit 108ae17 into master May 10, 2023
@MaineK00n MaineK00n deleted the MaineK00n/purego branch May 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant