Skip to content

Commit

Permalink
feat(ubuntu): add 24.04 noble (#377)
Browse files Browse the repository at this point in the history
  • Loading branch information
MaineK00n authored May 1, 2024
1 parent e644927 commit 781903e
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/fetch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
--health-timeout 5s
--health-retries 5
env:
Version: 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
Version: 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v3
Expand Down
12 changes: 6 additions & 6 deletions GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ clean-integration:

fetch-rdb:
integration/goval-dict.old fetch debian --dbpath=$(PWD)/integration/oval.old.sqlite3 7 8 9 10 11
integration/goval-dict.old fetch ubuntu --dbpath=$(PWD)/integration/oval.old.sqlite3 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
integration/goval-dict.old fetch ubuntu --dbpath=$(PWD)/integration/oval.old.sqlite3 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
integration/goval-dict.old fetch redhat --dbpath=$(PWD)/integration/oval.old.sqlite3 5 6 7 8 9
integration/goval-dict.old fetch oracle --dbpath=$(PWD)/integration/oval.old.sqlite3 5 6 7 8 9
integration/goval-dict.old fetch amazon --dbpath=$(PWD)/integration/oval.old.sqlite3 1 2 2022 2023
Expand All @@ -103,7 +103,7 @@ fetch-rdb:
integration/goval-dict.old fetch fedora --dbpath=$(PWD)/integration/oval.old.sqlite3 32 33 34 35

integration/goval-dict.new fetch debian --dbpath=$(PWD)/integration/oval.new.sqlite3 7 8 9 10 11
integration/goval-dict.new fetch ubuntu --dbpath=$(PWD)/integration/oval.new.sqlite3 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
integration/goval-dict.new fetch ubuntu --dbpath=$(PWD)/integration/oval.new.sqlite3 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
integration/goval-dict.new fetch redhat --dbpath=$(PWD)/integration/oval.new.sqlite3 5 6 7 8 9
integration/goval-dict.new fetch oracle --dbpath=$(PWD)/integration/oval.new.sqlite3 5 6 7 8 9
integration/goval-dict.new fetch amazon --dbpath=$(PWD)/integration/oval.new.sqlite3 1 2 2022 2023
Expand All @@ -119,7 +119,7 @@ fetch-redis:
docker run --name redis-new -d -p 127.0.0.1:6380:6379 redis

integration/goval-dict.old fetch debian --dbtype redis --dbpath "redis://127.0.0.1:6379/0" 7 8 9 10 11
integration/goval-dict.old fetch ubuntu --dbtype redis --dbpath "redis://127.0.0.1:6379/0" 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
integration/goval-dict.old fetch ubuntu --dbtype redis --dbpath "redis://127.0.0.1:6379/0" 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
integration/goval-dict.old fetch redhat --dbtype redis --dbpath "redis://127.0.0.1:6379/0" 5 6 7 8 9
integration/goval-dict.old fetch oracle --dbtype redis --dbpath "redis://127.0.0.1:6379/0" 5 6 7 8 9
integration/goval-dict.old fetch amazon --dbtype redis --dbpath "redis://127.0.0.1:6379/0" 1 2 2022 2023
Expand All @@ -131,7 +131,7 @@ fetch-redis:
integration/goval-dict.old fetch fedora --dbtype redis --dbpath "redis://127.0.0.1:6379/0" 32 33 34 35

integration/goval-dict.new fetch debian --dbtype redis --dbpath "redis://127.0.0.1:6380/0" 7 8 9 10 11
integration/goval-dict.new fetch ubuntu --dbtype redis --dbpath "redis://127.0.0.1:6380/0" 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
integration/goval-dict.new fetch ubuntu --dbtype redis --dbpath "redis://127.0.0.1:6380/0" 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
integration/goval-dict.new fetch redhat --dbtype redis --dbpath "redis://127.0.0.1:6380/0" 5 6 7 8 9
integration/goval-dict.new fetch oracle --dbtype redis --dbpath "redis://127.0.0.1:6380/0" 5 6 7 8 9
integration/goval-dict.new fetch amazon --dbtype redis --dbpath "redis://127.0.0.1:6380/0" 1 2 2022 2023
Expand All @@ -144,7 +144,7 @@ fetch-redis:

diff-cveid:
@ python integration/diff_server_mode.py --sample-rate 0.01 cveid debian 7 8 9 10 11
@ python integration/diff_server_mode.py --sample-rate 0.01 cveid ubuntu 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
@ python integration/diff_server_mode.py --sample-rate 0.01 cveid ubuntu 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
@ python integration/diff_server_mode.py --sample-rate 0.01 cveid redhat 5 6 7 8 9
@ python integration/diff_server_mode.py --sample-rate 0.01 cveid oracle 5 6 7 8 9
@ python integration/diff_server_mode.py --sample-rate 0.01 --arch x86_64 cveid oracle 5 6 7 8 9
Expand All @@ -161,7 +161,7 @@ diff-cveid:

diff-package:
@ python integration/diff_server_mode.py --sample-rate 0.01 package debian 7 8 9 10 11
@ python integration/diff_server_mode.py --sample-rate 0.01 package ubuntu 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
@ python integration/diff_server_mode.py --sample-rate 0.01 package ubuntu 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
@ python integration/diff_server_mode.py --sample-rate 0.01 package redhat 5 6 7 8 9
@ python integration/diff_server_mode.py --sample-rate 0.01 package oracle 5 6 7 8 9
@ python integration/diff_server_mode.py --sample-rate 0.01 --arch x86_64 package oracle 5 6 7 8 9
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ $ goval-dictionary fetch debian 7 8 9 10 11
- [Ubuntu(main)](https://security-metadata.canonical.com/oval/)
- [Ubuntu(sub)](https://people.canonical.com/~ubuntu-security/oval/)
```bash
$ goval-dictionary fetch ubuntu 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10
$ goval-dictionary fetch ubuntu 14.04 16.04 18.04 20.04 21.04 21.10 22.04 22.10 23.04 23.10 24.04
```
#### Usage: Fetch OVAL data from SUSE
Expand Down
3 changes: 3 additions & 0 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ const (
// Ubuntu2310 is Mantic Minotaur
Ubuntu2310 = "mantic"

// Ubuntu2404 is Noble Numbat
Ubuntu2404 = "noble"

// Debian7 is wheezy
Debian7 = "wheezy"

Expand Down
9 changes: 9 additions & 0 deletions fetcher/ubuntu/ubuntu.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,15 @@ func getOVALURL(version string) string {
default:
return "unknown"
}
case "24":
switch minor {
case "04":
return fmt.Sprintf(main, config.Ubuntu2404)
case "10":
return "unsupported"
default:
return "unknown"
}
default:
return "unknown"
}
Expand Down
2 changes: 1 addition & 1 deletion integration/diff_server_mode.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def diff_response(args: Tuple[str, str, str, str, str]):
f'Failed to diff_response..., err: This Release Version({args.release}) does not support test mode')
raise NotImplementedError
elif args.ostype == 'ubuntu':
if len(list(set(args.release) - set(['14.04', '16.04', '18.04', '19.10', '20.04', '20.10', '21.04', '21.10', '22.04', '22.10', '23.04', '23.10']))) > 0:
if len(list(set(args.release) - set(['14.04', '16.04', '18.04', '19.10', '20.04', '20.10', '21.04', '21.10', '22.04', '22.10', '23.04', '23.10', '24.04']))) > 0:
logger.error(
f'Failed to diff_response..., err: This Release Version({args.release}) does not support test mode')
raise NotImplementedError
Expand Down

0 comments on commit 781903e

Please sign in to comment.