Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fetch/redhat): fetch including-unpatched #388

Merged
merged 1 commit into from
May 9, 2024

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented May 3, 2024

What did you implement:

Red Hat OVALv2 provides OVALs that contains unpatched definitions.
This PR supports those OVAL.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

before

$ goval-dictionary fetch redhat 8
$ goval-dictionary select --by-package redhat 8 "vim-common" | grep "oval:com.redhat.cve:def"
$

after

$ goval-dictionary fetch redhat 8
$ goval-dictionary select --by-package redhat 8 "vim-common" | grep "oval:com.redhat.cve:def"
    DefinitionID: "oval:com.redhat.cve:def:20222819",
    ...
$

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this May 3, 2024
@MaineK00n MaineK00n force-pushed the MaineK00n/redhat-including-unpatched branch 2 times, most recently from 6227fa1 to d8cf101 Compare May 7, 2024 18:02
@MaineK00n MaineK00n requested a review from shino May 7, 2024 22:04
@MaineK00n MaineK00n force-pushed the MaineK00n/redhat-including-unpatched branch from d8cf101 to ee425bf Compare May 8, 2024 09:51
@MaineK00n MaineK00n force-pushed the MaineK00n/redhat-including-unpatched branch from ee425bf to 61fee7d Compare May 8, 2024 09:52
Copy link
Contributor

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@MaineK00n MaineK00n merged commit 0909b7a into master May 9, 2024
13 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/redhat-including-unpatched branch May 9, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants