Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances : ListPrivateNetworks missing paging ability #140

Merged
merged 3 commits into from
May 4, 2021

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented May 4, 2021

Description

The listPrivateNetworks call allows for paging on the API and we return the metadata in the go library. However, you can't pass in paging information to the function. This adds paging ability

Related Issues

n/a

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko requested a review from mamclaughlin May 4, 2021 19:03
@ddymko ddymko added the bug Something isn't working label May 4, 2021
mamclaughlin
mamclaughlin previously approved these changes May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #140 (3ed7c3b) into master (8fb2b30) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   55.00%   54.98%   -0.02%     
==========================================
  Files          23       23              
  Lines        1169     1173       +4     
==========================================
+ Hits          643      645       +2     
- Misses        264      265       +1     
- Partials      262      263       +1     
Impacted Files Coverage Δ
instance.go 55.74% <50.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb2b30...3ed7c3b. Read the comment docs.

mamclaughlin
mamclaughlin previously approved these changes May 4, 2021
@ddymko ddymko merged commit 73dcf0a into vultr:master May 4, 2021
@ddymko ddymko deleted the instance-list-networks-bug branch May 4, 2021 19:29
@ddymko ddymko mentioned this pull request May 4, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants