Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a panic when
http.Client.Do
returns an error. This issue is caused by trying to close the request body with defer before checking for an error (see golang/go#17780).I noticed this issue when running dnscontrol (PR StackExchange/dnscontrol#529) on my CI server, and I forgot to install
ca-certificates
in the image (resulting in the error:Get https://api.vultr.com/v1/account/info: x509: certificate signed by unknown authority
).Checklist: