Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Record Update Priority #67

Merged
merged 1 commit into from
Jun 2, 2020
Merged

DNS Record Update Priority #67

merged 1 commit into from
Jun 2, 2020

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Jun 2, 2020

Description

This will fix a bug in which you were not able to update the priority of a record to 0. It will introduce a backwards breaking change since now priority in the DNS Records struct will be a pointer to an int.

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko added the bug Something isn't working label Jun 2, 2020
@ddymko ddymko requested a review from mamclaughlin June 2, 2020 16:05
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   72.09%   72.09%           
=======================================
  Files          24       24           
  Lines        2684     2684           
=======================================
  Hits         1935     1935           
  Misses        377      377           
  Partials      372      372           
Impacted Files Coverage Δ
dns_records.go 73.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d9613...2b3525b. Read the comment docs.

@ddymko ddymko merged commit d79aa63 into vultr:master Jun 2, 2020
@ddymko ddymko mentioned this pull request Jun 2, 2020
3 tasks
@ddymko ddymko deleted the dns-priority branch September 22, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants