Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default tag checking for vultr_kubernetes resource #528

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

timurbabs
Copy link
Contributor

Description

The current code iterates over the node pools but immediately returns an error if the first node pool does not have the tag tf-vke-default. This means it does not check the remaining node pools for the required tag. As a result, if the node pool with the tf-vke-default tag is not the first in the list, the function erroneously returns an error like:

Error: unable to set resource kubernetes default node pool with tag tf-vke-default for <cluster_id>. 
You must set the default tag on one node pool before importing.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@optik-aper optik-aper merged commit 7e22cb3 into vultr:master Nov 22, 2024
3 checks passed
@optik-aper optik-aper mentioned this pull request Dec 6, 2024
@timurbabs timurbabs deleted the fix-resource-vultr-kubernetes branch December 19, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants