refactor: change default brotli compression level to 4 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not-Jayden
commented
Nov 5, 2024
| export const ZLIB_LEVEL = 6 as const | ||
| export const THRESHOLD_SIZE = 1024 | ||
| export const ZSTD_LEVEL = 2 | ||
| export const BROTLI_LEVEL = 4 |
There was a problem hiding this comment.
Actual change, just removed the as const's as they're redundant here on primitives.
|
Side note, were issues intentionally disabled in this repo? I intended to open this as a discussion first before making the change given it's ultimately an opinionated default (e.g. node seems to have |
I didn't realise the issues were disabled, I've turned them on now. |
vuolter
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default compression level of 11 is likely too extreme/slow for most use cases.
Cloudflare recommends a default of 4 https://blog.cloudflare.com/this-is-brotli-from-origin/#brotli-compression-to-11
the fastify-compress plugin changed their default based on this recommendation too fastify/fastify-compress#287 (comment)