Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regex more dynamic to include more objects #5

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

tdv85
Copy link
Contributor

@tdv85 tdv85 commented Aug 21, 2024

Pull Request Description

Type of Change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Other (please specify)

Description of Changes

See: https://chatgpt.com/share/26549618-ea88-4706-b2b8-c4586a5e8d18

Related Issues

Comparison: Before and After

Before:

After:

Testing Instructions

Validation

  • vusa::validate_script_proj() has been run
  • styler::style_active_file() has been run

Dependencies

Additional Information

Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • My code follows the project's coding standards
  • I have added/updated tests to cover my changes (if applicable)
  • The code is accompanied by comments
  • I have linked this PR to relevant issues (if applicable)

@tin900
Copy link
Contributor

tin900 commented Aug 22, 2024

Hi @tdv85 ,

Could you provide an example showcasing the old method vs the new one?

@tin900 tin900 self-requested a review August 22, 2024 06:43
R/clear_objects.R Show resolved Hide resolved
@tin900 tin900 merged commit e69751e into vusaverse:main Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants