fix: SSH Proxy command with Docker is only used when the host VM is enabled #48
+30
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @vvchik , thanks for your work on this plugin!
This PR allows the plugin to be used when using Vagrant with the Docker provider and no VM implied, but the Docker Engine directly.
My use case is https://github.com/jenkins-infra/jenkins-infra: I want to allow the Vagrant VM used for Puppet's manifest validation to be run without requiring Virtualbox but only a Docker Engine.
When doing so, the provisioning with the serverspec provider fails with an error related to an empty host/port in the method
use_jump_providerbecause there are no intermediate host VM: I'm using a direct container with SSH server in the container.So here is a proposed changed, that use the attribute
force_host_vmwhich value is set tofalseby default on almost all platforms: hashicorp/vagrant#8437.